Re: [Irssi-xmpp-dev] Problem with irssi-xmpp

[Colin Didier <cdidier@domain.hid>]

Nice.

I've Cc the mailing-list because some people some people may be interested.

* Mattias Eriksson <snaggen@domain.hid> [2008-08-22 09:03:45 +0200]:
> I backported the fix to the version just before the rewrite started and pushed
> it up to launchpad
> bzr branch lp:~snaggen/irssi-xmpp/before-rewrite-with-strip-codes
> 
> or look at it using the web
> https://code.launchpad.net/irssi-xmpp
> 
> anyway, I just wanted you to know where to find this backport.
> 
> //Mattias
> 
> fre 2008-08-22 klockan 05:14 +0200 skrev Colin Didier:
> 
>     * Mattias Eriksson <snaggen@domain.hid> [2008-08-21 10:01:49 +0200]:
>     > Hi,
>     >
>     > We just deployed irssi-xmpp as the command line client of choise on our
>     > company, however we found some issues when someone wanted to say "Lunch" in
>     > bold. He wrote ctrl-b Lunch ctrl-b, this caused all irssi-xmpp clients to get
>     > in to problems with the connection and our openfire server got in some problem
>     > too...
>     >
>     > So I don't know if the fix is to catch ctrl- combos or sanitize the input and
>     > remove potential harmful characters. Note, that from what I understand it gets
>     > xml-encoded correctly in loudmouth... so I don't know if the problems occure
>     > when the message is decoded when it is recieved again (and when the server
>     > processes it somehow).. I don't know, I just know that ctrl-b is not a friend
>     > of irssi-xmpp :)
>     >
>     > And the version we use is from CVS mid June. and loudmouth 1.2.3.
>     >
>     > //Mattias
> 
>     Hi Mattias,
> 
>     I've commited to the CVS repos a little fix for this. It seems that the
>     Ctrl-{B,C,F,G,R} combos aren't utf8 valid when the server process them,
>     so with ejabberd we get disconnected.
> 
>     With the fix, these combos are simply stripped of the messages when it
>     is beeing recoded with xmpp_recode_out(). But the issue is still there
>     with ctrl-f.
> 
>     Be aware that in the current CVS version, MUC aren't supported anymore,
>     but I will bring back the MUC support very soon.
> 
>     Thanks for reporting this bug.
> 
>     Cheers,
>       Colin
> 
> 

-- 
Colin Didier                                                http://cybione.org