[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [irssi-xmpp] Error in the code ?

On Wed, Jan 12, 2011 at 07:35:45PM +0100, Jerome MARTY wrote:
> Hello,
> 
> While porting this plugin on Android, I found strange to add a signal in
> a deinit function so I would like to know if this patch is correct.

Fixed, thank you.

> diff --git a/src/core/xep/disco.c b/src/core/xep/disco.c
> index afc2c77..7719e35 100644
> --- a/src/core/xep/disco.c
> +++ b/src/core/xep/disco.c
> @@ -171,7 +171,7 @@ void
>  disco_deinit(void)
>  {
>         signal_remove("server connected", sig_connected);
> -       signal_add("server disconnected", sig_disconnected);
> +       signal_remove("server disconnected", sig_disconnected);
>         signal_remove("xmpp recv iq", sig_recv_iq);
>         g_slist_free(my_features);
>  }
> 
> 
> 

-- 
                                            http://cybione.org/~cdidier/